Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngctl: small improvements #101

Open
1 of 2 tasks
wey-gu opened this issue Nov 29, 2021 · 6 comments
Open
1 of 2 tasks

ngctl: small improvements #101

wey-gu opened this issue Nov 29, 2021 · 6 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Nov 29, 2021

First, it's awesome to have ngctl, really love it, thank you so much!!

  • In initial connection, the first line of +--------------------+ should be better newline-ed:
$ngctl console
(root@nebula) [(none)]> show spaces
(root@nebula) [(none)]> +--------------------+
| Name               |
+--------------------+
| "basketballplayer" |
| "shareholding"     |
+--------------------+
  • Possible to support UP-btn for history commands or even Ctrl-R?
@wey-gu wey-gu changed the title ngctl: output format: new line missing ngctl: small improvements Nov 29, 2021
@veezhang
Copy link
Contributor

veezhang commented Mar 8, 2022

@wey-gu

I don't have this problem in first improvement here.
image

I found that nebula-console is not supported UP-btn or Ctrl-R, is that right?

@wey-gu
Copy link
Contributor Author

wey-gu commented Mar 8, 2022

@wey-gu

I don't have this problem in first improvement here. image

I found that nebula-console is not supported UP-btn or Ctrl-R, is that right?

Thanks @veezhang !
Yes, we could ignore the first one, maybe to support UP-btn or Ctrl-R would make it more handy to users ;)

@veezhang
Copy link
Contributor

veezhang commented Mar 9, 2022

@wey-gu
But I found that the nebula-console have not supported yet. And this feature is depends on it.

How about advise the nebula-console to support first?

@wey-gu
Copy link
Contributor Author

wey-gu commented Mar 9, 2022

But I found that the nebula-console have not supported yet. And this feature is depends on it.

How about advise the nebula-console to support first?

Got it, will do so.

@veezhang
Copy link
Contributor

veezhang commented Mar 9, 2022

Thanks

@wey-gu
Copy link
Contributor Author

wey-gu commented Mar 10, 2022

@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

3 participants