Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Remove songs from the queue by swiping #1163

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Sublimeful
Copy link

@Sublimeful Sublimeful commented Aug 24, 2023

I love using this app but find it slightly tedious to have to hold down on each song in the queue to remove it. Therefore, based on issue #540, I've decided to add this feature. Please let me know if this would be an appropriate enhancement to this wonderful app!

@Sublimeful Sublimeful changed the title Remove songs from the queue by swiping right Remove songs from the queue by swiping Aug 24, 2023
@vfsfitvnm
Copy link
Owner

Thanks for taking a stub at this, and I apologize for the late reply.

I didn't run the code, but from what I see, the song gets suddenly removed from the list (an animation is mandatory).

Other than that, extra attention is needed when mixing vertical and horizontal drag gestures in compose (#154 (comment), https://stackoverflow.com/questions/74391528/detect-strict-horizontal-drag-gestures-in-jetpack-compose).

@Sublimeful
Copy link
Author

Hey @vfsfitvnm, I added the animations like you said. But I am not sure what you mean when you mention mixing vertical and horizontal drag gestures, as I am using the draggable modifier with the orientation set to horizontal only. Could you please clarify what you mean? Also, please let me know if there is a better way to go about implementing this feature, as this is my first time working with compose and Android development in general 😅. Thank you!

@ashish-506
Copy link

There is a request from my side to add a button to share the whole playlist at once in the form of a link which can be shared to different platforms like WhatsApp and Instagram.

@Pervysage1069
Copy link

How can I apply thus to my apk someone plz help😭😭

@andietablante18
Copy link

Is this feature in the APK yet?

@Sublimeful
Copy link
Author

Hey guys, since this PR has not been merged yet, if you want a built apk with this feature then you can check out my fork here. You can download the apk in the "releases" section.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants