This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Extracted hardcoded string resources. Added some Spanish translations. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #171 |
This comment was marked as spam.
This comment was marked as spam.
|
Need to add full album download for offline listening |
|
@Ketsusho @imsyryus Why are you writing this here? This pull request is not about your requirements at all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of everything. I'm in love with this app. And as a native spanish speaker, I would like to contribute with translations.
The strings.xml file for translating files in Android Studio projects was not found, and I've seen that all of the strings are inside the code instead on a proper table.
So they are added to the new strings.xml file.
I've already did some translations and everything seems to work fine.
If this commit is valid I could serve another batch of translations to the spanish language and to remove hardcoded strings.
Thank you 😊