Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filter Mechanism for Target in Move Refactoring #18

Open
1 of 2 tasks
HeikoKlare opened this issue Nov 9, 2023 · 5 comments
Open
1 of 2 tasks

Add Filter Mechanism for Target in Move Refactoring #18

HeikoKlare opened this issue Nov 9, 2023 · 5 comments
Assignees
@ShahzaibIbrahim
Labels
Enhancement A Request for an Enhancement of an Existing Feature Good First Issue A Good Issue to Start Eclipse Development JDT Issues for JDT

Comments

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Nov 9, 2023 •
edited by ShahzaibIbrahim
Loading

Current Behavior

The move refactoring provides a tree view in which the move target has to be selected. The target has to be searched manually within the complete project tree, as there is no search or filter mechanism, which is quite cumbersome when having a large number of projects.

Image

Expected Behavior

The target selection dialog for the move refactoring should provide a filtering mechanism, which at least allows to filter the project names or even the names of elements within the projects.

The filter should support common functionality like partial inputs and wildcards, i.e., eclipse.*.tools should, for example, match org.eclipse.internal.tools.

  • Provide a filter input box on top of the tree view that allows to filter for project name:
    Image
  • Optional: Enhance the filter input box to also filter for all labels in the tree view, such as package names:
    Image

Link to original issue -> eclipse-jdt/eclipse.jdt.ui#1337
@HeikoKlare HeikoKlare converted this from a draft issue Nov 9, 2023
@HeikoKlare HeikoKlare added JDT Issues for JDT Enhancement A Request for an Enhancement of an Existing Feature Good First Issue A Good Issue to Start Eclipse Development labels Nov 9, 2023
@HeikoKlare HeikoKlare moved this from 📋 Backlog to 🔖 Ready in Eclipse Nov 9, 2023
@fedejeanne
Copy link

@ShahzaibIbrahim I assigned the ticket to you, please change its status once you start working on it. Thanks!

@ShahzaibIbrahim ShahzaibIbrahim moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in Eclipse Nov 29, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Work: Short to ✅ Done in Eclipse Dec 6, 2023
@ShahzaibIbrahim ShahzaibIbrahim mentioned this issue Dec 6, 2023
Closed
@HeikoKlare HeikoKlare reopened this Dec 6, 2023
@ShahzaibIbrahim ShahzaibIbrahim moved this from ✅ Done to 🏗 In Work: Short in Eclipse Jan 4, 2024
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🏗 In Work: Short to 👀 In Review in Eclipse Jan 5, 2024
ShahzaibIbrahim added a commit to ShahzaibIbrahim/eclipse.jdt.ui that referenced this issue Mar 9, 2024
@ShahzaibIbrahim
Add Filter Mechanism for Target in Move Refactoring#18
9558771 
To let user filter the projects or packages from a search bar in a move
refactor dialog.

Fixes vi-eclipse/Eclipse-JDT#18
@ShahzaibIbrahim ShahzaibIbrahim mentioned this issue Mar 9, 2024
Open
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Eclipse Apr 17, 2024
@ShahzaibIbrahim ShahzaibIbrahim mentioned this issue Apr 17, 2024
Merged
@fedejeanne
Copy link

@ShahzaibIbrahim you probably closed this one by mistake because you wrote Fixes https://github.com/vi-eclipse/Eclipse-JDT/issues/18 in the commit message.

Please reword the commit appropriately and only mention "official" issues (issues in the Eclipse repositories).

Change the status of this issue accordingly too ;)

@ShahzaibIbrahim
Copy link

@ShahzaibIbrahim you probably closed this one by mistake because you wrote Fixes https://github.com/vi-eclipse/Eclipse-JDT/issues/18 in the commit message.

Please reword the commit appropriately and only mention "official" issues (issues in the Eclipse repositories).

Change the status of this issue accordingly too ;)

Do you know where I can find the official issue for this one?

@fedejeanne
Copy link

Do you know where I can find the official issue for this one?

If it's not already linked in our internal issue then it's probably not been created yet. Please create it and link it.

@fedejeanne fedejeanne reopened this Apr 22, 2024
@HeikoKlare
Copy link
Contributor Author

Was closed by accident again

@HeikoKlare HeikoKlare reopened this Apr 22, 2024
@ShahzaibIbrahim ShahzaibIbrahim moved this from ✅ Done to 👀 In Review in Eclipse Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahzaibIbrahim ShahzaibIbrahim

Labels
Enhancement A Request for an Enhancement of an Existing Feature Good First Issue A Good Issue to Start Eclipse Development JDT Issues for JDT
Projects
Eclipse
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Filter Mechanism for Target in Move Refactoring#18 ShahzaibIbrahim/eclipse.jdt.ui
3 participants
@HeikoKlare @fedejeanne @ShahzaibIbrahim