Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maxmind lib #840

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

perdedora
Copy link
Member

Closes #836

This PR updates maxmind database to the newer lib and add possibility to switch between bases from maxmind.

I've tried my best to explain how to setup. This is needed because maxmind updates every tuesday and thursday, which it's not viable to keep pushing the database updates here.
Also because we're using the old format .dat instead of the newer one .mmdb

@abdullahdevrel
Copy link

I made a feature request here to use IPinfo's country database: #841

The database provides full accuracy, comes in MMDB format, has a simple download mechanism, and does not require end users to have their own access token to download the database.

@Zankaria
Copy link

I made a feature request here to use IPinfo's country database: #841

The database provides full accuracy, comes in MMDB format, has a simple download mechanism, and does not require end users to have their own access token to download the database.

The only "benchmark" I saw of it suggests that it's less complete and up to date than the free maxmind database https://github.com/sapics/ip-location-db?tab=readme-ov-file#accuracy-of-database

@abdullahdevrel
Copy link

abdullahdevrel commented Nov 15, 2024

@Zankaria

The only "benchmark" I saw of it suggests that it's less complete and up to date than the free maxmind database >https://github.com/sapics/ip-location-db?tab=readme-ov-file#accuracy-of-database

You made a mistake. Our database, "IPinfo," is not listed in the README. You have confused our data with someone else's data.

Our IP to Country database is not just better than all free databases; it is better than all paid databases as well. The reason is that we use active measurement-based geolocation, which is not the standard method in the industry. We are sharing our full accuracy and daily updates without any compromise to support open-source projects like this.

https://ipinfo.io/accuracy

@RealAngeleno RealAngeleno merged commit 2f41f31 into vichan-devel:dev Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants