Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure/Refactor test cases #25

Open
vickumar1981 opened this issue Dec 4, 2018 · 0 comments
Open

Restructure/Refactor test cases #25

vickumar1981 opened this issue Dec 4, 2018 · 0 comments
Milestone

Comments

@vickumar1981
Copy link
Owner

The class that stores test case information needs to be refactored:

https://github.com/vickumar1981/stringdistance/blob/master/src/test/scala/fixtures/TestCases.scala#L6

TestCase and TestSoundCase are case classes with value members: Option[T] where T is either an Int or Double depending on whether the test is for a distance or fuzzy score metric. These classes need to be generalized to support adding more test cases with greater flexibility.

String and String sound tests may need to be refactored as well to support any new model:

https://github.com/vickumar1981/stringdistance/blob/master/src/test/scala/TestStringDistance.scala

https://github.com/vickumar1981/stringdistance/blob/master/src/test/scala/TestStringSoundScore.scala

@vickumar1981 vickumar1981 added this to the 1.1.0 milestone Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant