-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seekbar goes crazy when out of width #810
Comments
Any updates? |
Still having this behaviour, when moving out from the end it keeps at the end, but when moving out of the start, it goes crazy. |
I have solved it getting the videogular2 package out of node_modules and using it as an angular element and modifying this code on videogular2/src/controls/vg-scrub-bar/vg-scrub-bar.jsvg-scrub-bar.js
|
… out Fix issue videogular#810, seekbar doesn't go crazy when cursor is sliding the seekbar and gets out of the player. Instead getting offsetX, now get the cursor x coordinate and calculates its position relative to the scrub-bar to calculate the correct position. BREAKING CHANGE: 🧨 none ✅ Closes: videogular#810
I have fixed it better and created a pull-request. |
Description
When I move out of seekbar (its width to be correct) it nondeterministicaly jumps to random times.
Current setup
https://mybrowser.fyi/report/5c3f57cc8d118e0014b1a7d1 (Chrome Canary)
https://mybrowser.fyi/report/5c3f57f78d118e0014b1a7d2 (Vivaldi)
https://mybrowser.fyi/report/5c3f582f8d118e0014b1a7d4 (Safari)
Expected Behavior
When I move out of seekbar it should stay at 00:00/end of video.
Actual Behavior
It nondeterministicaly jumps to random times.
Steps to Reproduce
Attachments
You can try it here
https://videogular.github.io/videogular2-showroom/#/single-player
The text was updated successfully, but these errors were encountered: