Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang… #890

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang… #890

wants to merge 2 commits into from

Commits on Mar 31, 2020

  1. fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang… 

    …es() in click handler

I injected `public cdr: ChangeDetectorRef` into VgPlaybackButton and called `detectChanges()` as the
last action in the `updatePlaybackSpeed()` method. This fixes videogular#845. I had to make some innocuous
changes to some spec files to get it to build because of compile-time errors when running `npm run
build`.

845
    @vicatcu
    vicatcu committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    a56c7da View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Merge branch 'master' into fix-issue-845

    @vicatcu
    vicatcu authored Jun 8, 2020
    Configuration menu
    Copy the full SHA
    68fb2e8 View commit details
    Browse the repository at this point in the history