Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting BitFieldVec.get(Range<usize>) #47

Open
RagnarGrootKoerkamp opened this issue Aug 10, 2024 · 3 comments
Open

Consider supporting BitFieldVec.get(Range<usize>) #47

RagnarGrootKoerkamp opened this issue Aug 10, 2024 · 3 comments

Comments

@RagnarGrootKoerkamp
Copy link
Contributor

It would be nice if this worked as a convenience when porting existing code from Vec. But it would probably involve quite some wrapper code so maybe not worth it.

@vigna
Copy link
Owner

vigna commented Aug 10, 2024

So that would return some struct implementing BitFieldSlice, and giving a view on the range, right?

@RagnarGrootKoerkamp
Copy link
Contributor Author

Yes exactly. Hence why it may be too much overhead.

@vigna
Copy link
Owner

vigna commented Aug 10, 2024

Well it's certainly something that should be done. It's also likely we can get away with a support struct in BitFieldSlice. We're all in vacation now but I think it's a good idea.

The APIs we have now are the one we were able to write, but there's a lot of stuff missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants