From e121814f17206a72eedf20d2bd6888d14ceda67e Mon Sep 17 00:00:00 2001 From: Liang-Chi Hsieh Date: Wed, 9 Oct 2024 10:23:14 -0600 Subject: [PATCH] skip large partition number shuffle on macos runners --- .github/actions/rust-test/action.yaml | 1 - native/core/src/execution/datafusion/shuffle_writer.rs | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/actions/rust-test/action.yaml b/.github/actions/rust-test/action.yaml index 4ff144eb6..a1cde99ba 100644 --- a/.github/actions/rust-test/action.yaml +++ b/.github/actions/rust-test/action.yaml @@ -62,6 +62,5 @@ runs: - name: Run Cargo test shell: bash run: | - ulimit -n 102400 cd native RUST_BACKTRACE=1 cargo test diff --git a/native/core/src/execution/datafusion/shuffle_writer.rs b/native/core/src/execution/datafusion/shuffle_writer.rs index f0078e883..46c3d4995 100644 --- a/native/core/src/execution/datafusion/shuffle_writer.rs +++ b/native/core/src/execution/datafusion/shuffle_writer.rs @@ -1598,6 +1598,7 @@ mod test { #[test] #[cfg_attr(miri, ignore)] // miri can't call foreign function `ZSTD_createCCtx` + #[cfg(not(target_os = "macos"))] // Github MacOS runner fails with "Too many open files". fn test_large_number_of_partitions() { shuffle_write_test(10000, 10, 200, Some(10 * 1024 * 1024)); shuffle_write_test(10000, 10, 2000, Some(10 * 1024 * 1024)); @@ -1605,6 +1606,7 @@ mod test { #[test] #[cfg_attr(miri, ignore)] // miri can't call foreign function `ZSTD_createCCtx` + #[cfg(not(target_os = "macos"))] // Github MacOS runner fails with "Too many open files". fn test_large_number_of_partitions_spilling() { shuffle_write_test(10000, 100, 200, Some(10 * 1024 * 1024)); }