Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular 6 (rxjs 6) #19

Open
ArielAleksandrus opened this issue Jun 11, 2018 · 3 comments
Open

Add support for Angular 6 (rxjs 6) #19

ArielAleksandrus opened this issue Jun 11, 2018 · 3 comments

Comments

@ArielAleksandrus
Copy link

Rxjs has now a new version, and subject is now imported directly from 'rxjs'
Operators, like map, filter, switch map can be imported from 'rxjs/operator'

Problem is: even fixing imports, broadcaster.js fails on 'return this._eventBus.asObservable().filter(...)'

Error is:

this._eventBus.asObservable(...).filter is not a function
    at Broadcaster.push../node_modules/ng2-cable/broadcaster.js.Broadcaster.on
@ArielAleksandrus
Copy link
Author

I've made a PR to fix it #20
Actually, I think it would be better to be on a branch or separate repository, like 'ng6-cable'

@viktor-shmigol
Copy link
Owner

viktor-shmigol commented Jun 14, 2018

@ArielAleksandrus I use angular 6.0.0 and rxjs 6.1.0. I do not have any issue at all. Here is my packages list:

@angular-devkit/build-angular         0.6.0
@angular/animations                   6.0.0
@angular/cli                          6.0.0
@angular/common                       6.0.0
@angular/compiler                     6.0.0
@angular/compiler-cli                 6.0.0
@angular/core                         6.0.0
@angular/forms                        6.0.0
@angular/http                         6.0.0
@angular/platform-browser             6.0.0
@angular/platform-browser-dynamic     6.0.0
@angular/router                       6.0.0
core-js                               2.5.5
rxjs                                  6.1.0
rxjs-compat                           6.1.0
ts-node                               6.0.3
typescript                            2.7.2

Also I am going to replace "brodcaster" with https://github.com/viktor-shmigol/ngx-global-events.
So, there is no sence to merge your PR.

@dustinblanchard
Copy link

@viktor-shmigol do you have a timeframe for these changes? The peer dependencies are interfering with updating to the latest angular versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants