Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sub_units for several currencies #9

Open
shridharama opened this issue Feb 28, 2019 · 3 comments
Open

Incorrect sub_units for several currencies #9

shridharama opened this issue Feb 28, 2019 · 3 comments

Comments

@shridharama
Copy link

I happen to be looking for python libraries related that offer some capability of major unit to minor unit conversion, and came across your repo. Just wanted to let you know that the sub_units in many currencies here https://github.com/vimeo/py-money/blob/master/money/currency.py are out of date. Ex: CLP, ISK, KRW, etc should have sub_unit as 1, not 100. The full list can be found here https://www.currency-iso.org/en/home/tables/table-a1.html.

@nickyr
Copy link
Contributor

nickyr commented Mar 4, 2019

Mmm thanks for the info, will investigate.

@nickyr
Copy link
Contributor

nickyr commented May 10, 2019

Hey there, just letting you know I'm not finding time to prioritize this. If you'd like to open a PR, I'll review it though!

@wapiflapi
Copy link

Maybe worth following an approach like https://github.com/dahlia/iso4217/blob/main/setup.py which downloads the data during settup.py install, basically having it as a dependency.

Might have some issues with corporate proxies and such, but you could have a default xml file in the repository (possibly out of date) on which to fall back on.

I might look at this at some point if I need the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants