Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The install.sh -n option does not correctly change the index.theme name #369

Open
comsoi opened this issue Feb 5, 2025 · 0 comments
Open

Comments

@comsoi
Copy link

comsoi commented Feb 5, 2025

Describe the bug
When using the -n or --name option to specify a custom theme name, two issues occur:

    • The Name field in index.theme files remains unchanged (default: Name=WhiteSur).
    • Dark/light variant theme names (e.g., WhiteSur-dark) are not dynamically renamed, causing missing variants like {custom-name}-dark.

To Reproduce
Run the install script with a custom name:

./install.sh -n "NewName"

Expected behavior

  1. All index.theme files should have Name={custom-name} (e.g., Name=NewName).
  2. Dark/Light themes should be named {custom-name}-dark and {custom-name}-light, with corresponding Name fields in their index.theme files.

Desktop (please complete the following information):

  • OS: Arch Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant