Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param usePrivateFiles in Builder.useSerializerInDisk() is missleading #50

Open
AlexTrotsenko opened this issue Nov 9, 2017 · 0 comments

Comments

@AlexTrotsenko
Copy link

Javadoc for usePrivateFiles params in Builder.useSerializerInDisk() says: "true if you want to use {@link Context#MODE_PRIVATE} with the default disk cache folder."

But, as far as I see, both folder below refers to the internal storage and Context.MODE_PRIVATE is used by default:

  • context.getDir(CACHE_FILE_PREFIX + this.id, Context.MODE_PRIVATE)
  • new File(context.getCacheDir().getPath() + "/" + CACHE_FILE_PREFIX + "/" + this.id)

So, the only difference is the path: later creates folder in the cache folder, which might be cleaned-up by the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant