-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NBA by Conference? #8
Comments
Thanks, that would be a slightly different API call and some more code to change. I'm not actively making changes to this, but if anyone wants to submit a PR for it. |
Thanks for responding. I totally understand you are not actively maintaining this. It's a great module. |
Thanks! Yes, though I agree by Conference would be nice as the NBA playoffs get closer |
Hi there, I know it's been almost two years since you asked this question, but I just installed this module and managed to get this feature working on my mirror. If you change row 278 of MMM-MyStandings.js to Then update your config groups to "Western Conference" and "Eastern Conference", it should aggregate the standings by conference. Not sure if other fans would agree that this is the way NBA standings should be read, but I could certainly submit a PR if others agree. |
Thanks for this module ! It's great ! Instead of breaking out the table by Divisions, is it possible for NBA to show by East and West Conferences instead?
I've set "showByDivision: false" but it still groups by division.
The text was updated successfully, but these errors were encountered: