Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBA by Conference? #8

Open
chansters opened this issue Jan 12, 2021 · 4 comments
Open

NBA by Conference? #8

chansters opened this issue Jan 12, 2021 · 4 comments

Comments

@chansters
Copy link

Thanks for this module ! It's great ! Instead of breaking out the table by Divisions, is it possible for NBA to show by East and West Conferences instead?

I've set "showByDivision: false" but it still groups by division.

@vincep5
Copy link
Owner

vincep5 commented Jan 15, 2021

Thanks, that would be a slightly different API call and some more code to change. I'm not actively making changes to this, but if anyone wants to submit a PR for it.

@chansters
Copy link
Author

Thanks for responding. I totally understand you are not actively maintaining this. It's a great module.

@vincep5
Copy link
Owner

vincep5 commented Jan 16, 2021

Thanks! Yes, though I agree by Conference would be nice as the NBA playoffs get closer

@nemmy187
Copy link

Hi there,

I know it's been almost two years since you asked this question, but I just installed this module and managed to get this feature working on my mirror. If you change row 278 of MMM-MyStandings.js to
sport = "basketball/nba/standings?level=2&sort=gamesbehind:asc,winpercent:desc";

Then update your config groups to "Western Conference" and "Eastern Conference", it should aggregate the standings by conference.
{ league: "NBA", groups: ["Eastern Conference", "Western Conference"] }

Not sure if other fans would agree that this is the way NBA standings should be read, but I could certainly submit a PR if others agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants