Corrige exibição de planos apenas para produtos de assinatura #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3llaris
requested review from
mfcastellani and
gcaixeta
and removed request for
a team
| 'custom_attributes' => array( | ||
| 'data-plan-info' => json_encode($plans['infos']) | ||
| ) | ||
| )); |
There was a problem hiding this comment.
Man, o que acha de fazermos assim?
if (preg_match('/variable-subscription/', $product_type)) {
$label = __('Plano padrão da Vindi', VINDI_IDENTIFIER);
$description = __('Selecione o plano padrão da Vindi que deseja relacionar a esse produto caso não especifique na variação', VINDI_IDENTIFIER);
} else if (preg_match('/simple-subscription/', $product_type)) {
$label = __('Plano da Vindi', VINDI_IDENTIFIER);
$description = __('Selecione o plano da Vindi que deseja relacionar a esse produto', VINDI_IDENTIFIER);
}
woocommerce_wp_select(array(
'id' => 'vindi_subscription_plan',
'label' => $label,
'options' => $plans['names'],
'description' => $description,
'desc_tip' => true,
'value' => $selected_plan,
'custom_attributes' => array(
'data-plan-info' => json_encode($plans['infos'])
)
));
|
Estarei fechando esse PR até encontrar uma melhor solução para o problema e verificar a questão dos testes automatizados. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #138
Motivação
Como reportado na issue #138, os planos da Vindi estão aparecendo para produtos simples e outras variações de produtos. Os planos devem apenas aparecer para produtos de assinatura (simple subscription ou variable subscription).
Solução Proposta
Estou adicionando a label da seleção dos planos para a condição do tipo de produto de assinatura.