From a0681eed2b5234c0a4d9600be3f400945056b84f Mon Sep 17 00:00:00 2001
From: Federico Poli <fpoli@users.noreply.github.com>
Date: Tue, 22 Aug 2023 17:08:33 +0200
Subject: [PATCH] Sync written files (#1447)

Dropping a file will ignore errors in synchronizing in-memory
(meta)data to disk. Calling `sync_all` gives instead a result on
which to panic.
---
 jni-gen/systest/build.rs                              |  1 +
 prusti-launch/src/bin/prusti-rustc.rs                 |  2 ++
 .../counterexample_translation_refactored.rs          |  1 +
 smt-log-analyzer/src/state.rs                         |  1 +
 viper-sys/build.rs                                    |  1 +
 viper/src/cache.rs                                    | 11 +++++++++--
 6 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/jni-gen/systest/build.rs b/jni-gen/systest/build.rs
index 758fb05c0a6..4a690f335f8 100644
--- a/jni-gen/systest/build.rs
+++ b/jni-gen/systest/build.rs
@@ -20,6 +20,7 @@ fn main() {
             let fname = deps_dir.path().join("asm.jar");
             let mut dest = File::create(fname.clone()).unwrap();
             copy(&mut response.into_reader(), &mut dest).unwrap();
+            dest.sync_all().unwrap();
             fname.to_str().unwrap().to_string()
         }
     };
diff --git a/prusti-launch/src/bin/prusti-rustc.rs b/prusti-launch/src/bin/prusti-rustc.rs
index 230b71d852c..4883b25b68f 100644
--- a/prusti-launch/src/bin/prusti-rustc.rs
+++ b/prusti-launch/src/bin/prusti-rustc.rs
@@ -113,6 +113,7 @@ fn process(mut args: Vec<String>) -> Result<(), i32> {
         for arg in cmd.get_args() {
             writeln!(file, "{}", arg.to_str().unwrap()).unwrap();
         }
+        file.sync_all().unwrap();
     }
     if let Ok(path) = env::var("PRUSTI_RUSTC_LOG_ENV") {
         let mut file = std::fs::File::create(path).unwrap();
@@ -125,6 +126,7 @@ fn process(mut args: Vec<String>) -> Result<(), i32> {
             )
             .unwrap();
         }
+        file.sync_all().unwrap();
     }
 
     let exit_status = cmd.status().unwrap_or_else(|e| {
diff --git a/prusti-viper/src/encoder/counterexamples/counterexample_translation_refactored.rs b/prusti-viper/src/encoder/counterexamples/counterexample_translation_refactored.rs
index 105d3a3a7b8..159cf1a39af 100644
--- a/prusti-viper/src/encoder/counterexamples/counterexample_translation_refactored.rs
+++ b/prusti-viper/src/encoder/counterexamples/counterexample_translation_refactored.rs
@@ -36,6 +36,7 @@ pub fn backtranslate(
         let label_markers = translator.get_label_markers(true);
         let mut file = std::fs::File::create(path).unwrap();
         serde_json::to_writer_pretty(&mut file, &label_markers).unwrap();
+        file.sync_all().unwrap();
     }
 
     let counterexample_entry_vec = translator.process_entries(position_manager, &label_markers);
diff --git a/smt-log-analyzer/src/state.rs b/smt-log-analyzer/src/state.rs
index c519d1ca99e..7f406e86e66 100644
--- a/smt-log-analyzer/src/state.rs
+++ b/smt-log-analyzer/src/state.rs
@@ -667,6 +667,7 @@ impl State {
                 self.traced_quantifier_triggers.as_ref().unwrap().as_bytes(),
             )
             .unwrap();
+            file.sync_all().unwrap();
         }
     }
 
diff --git a/viper-sys/build.rs b/viper-sys/build.rs
index 6ec69d9eb11..e75b3805cc6 100644
--- a/viper-sys/build.rs
+++ b/viper-sys/build.rs
@@ -26,6 +26,7 @@ fn main() {
             let fname = deps_dir.path().join("asm.jar");
             let mut dest = File::create(fname.clone()).unwrap();
             copy(&mut response.into_reader(), &mut dest).unwrap();
+            dest.sync_all().unwrap();
             fname.to_str().unwrap().to_string()
         }
     };
diff --git a/viper/src/cache.rs b/viper/src/cache.rs
index 5c380c4da93..4ed6eb89561 100644
--- a/viper/src/cache.rs
+++ b/viper/src/cache.rs
@@ -98,8 +98,15 @@ impl PersistentCache {
         match fs::File::create(cache_loc) {
             Ok(f) => {
                 info!("Saving cache to \"{}\"", cache_loc.display());
-                bincode::serialize_into(&mut io::BufWriter::new(f), &ResultCache::from(self))
-                    .unwrap_or_else(|e| error!("Failed to write cache: {e}"));
+                let mut cache_buffer = io::BufWriter::new(f);
+                bincode::serialize_into(&mut cache_buffer, &ResultCache::from(self))
+                    .unwrap_or_else(|e| error!("Failed to serialize the cache: {e}"));
+                match cache_buffer.into_inner() {
+                    Err(e) => error!("Failed to flush the cache file: {e}"),
+                    Ok(f) => f
+                        .sync_all()
+                        .unwrap_or_else(|e| error!("Failed to sync the cache file to disk: {e}")),
+                }
             }
             Err(e) => error!("Failed to create cache file: {e}"),
         }