Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SED-ML files do not simulate all SBML files #6

Open
jonrkarr opened this issue Mar 1, 2022 · 1 comment
Open

[BUG] SED-ML files do not simulate all SBML files #6

jonrkarr opened this issue Mar 1, 2022 · 1 comment
Assignees

Comments

@jonrkarr
Copy link

jonrkarr commented Mar 1, 2022

Example: https://github.com/virtualcell/vcdb/blob/main/published/biomodel/omex/sbml/biomodel_12119723.omex

The archive has 6 SBML files, but the SED-ML only simulates 3. The native version, only has one VCML model. Taken together, this seems likely to be a bug.

This may be intentional. I'm raising this in case this isn't intentional.

@jonrkarr jonrkarr changed the title SED-ML files do not simulate all SBML files [BUG] SED-ML files do not simulate all SBML files Mar 1, 2022
@jonrkarr jonrkarr added the bug Something isn't working label Mar 2, 2022
@moraru moraru removed the bug Something isn't working label Apr 7, 2022
@moraru
Copy link
Member

moraru commented Apr 7, 2022

This is intentional - for now, On export we do create all SBML translations of the model(s) encoded in VCML but we do not currently create simulations/tasks for simulations that currently do not have saved simulation results in the VCDB database.

This can result in OMEX files with "unused" models. In the future, we may either remove these models or add simulations based on manual inspection of their use in publication.

@moraru moraru assigned vcfrmgit and unassigned danv61 and moraru Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants