Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Release Page not Updating #254

Closed
nithujohn opened this issue May 19, 2022 · 7 comments
Closed

Data Release Page not Updating #254

nithujohn opened this issue May 19, 2022 · 7 comments
Assignees

Comments

@nithujohn
Copy link

Hi @scottcain, it looks like the data release page is not updating for a while (since May 6th). Please have a look. Also the front page is partially updating. Thanks!
image

@scottcain
Copy link
Contributor

I just wrote a comment on #222 This is a critical bug that is being addressed now but unfortunately is not an easy fix.

@ghost ghost added the WP_1 label Jun 3, 2022
@b-f-chan
Copy link
Contributor

b-f-chan commented Jun 3, 2022

Assign to @UmmulkiramR to investigate - There is currently a limit to the download size due to one of the libraries we are using in the Singularity code, I think @joneubank first suggestion was to investigate that library and see if there is something else out there we can use (please connect with him for details)

@ghost
Copy link

ghost commented Jun 14, 2022

@joneubank
Copy link

Our dataset has grown to now be too large to build a single archive with the tools in our code base. We have theorized that the issue is based on the Java language limit on Array length (MAX_INTEGER which is 2^32 elements, approx 2Gb size limit) that is being overcome by our archive library when it converts the data to a byte array. This means that we will need to either find a new library that is not limited in this way, or we will need to stop building an archive of the full data set.

@ghost
Copy link

ghost commented Jul 12, 2022

We have a temporary fix for this Provide isolated fasta downloading functionality #279 and Change Tar library header properties for unstuck bundling issues #39

We will move this to prod in day or two. Currently placing this ticket in backlog as we wait for a long term solution to this.

@UmmulkiramR
Copy link

UmmulkiramR commented Jul 13, 2022

@sifavahora
Just to be clear - as we have discussed, only the isolated fasta downloading functionality #279 would be moved to prod.

Code changes to resolve virusseq/singularity#39 would be moved to testing once you give a go-ahead.

@ghost
Copy link

ghost commented Jul 20, 2022

We decided to use solution virusseq/singularity#39 as that was the best.
This bug is resolved. However we are planning to redesign the page, Will capture requirements in subsequent tickets.
Closing this ticket.

@ghost ghost closed this as completed Jul 20, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants