Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Rendering an empty animation with the GIF encoder may prompt webcam image captures. #181

Open
chrisgervang opened this issue Oct 11, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@chrisgervang
Copy link
Collaborator

chrisgervang commented Oct 11, 2021

Describe the bug
When hubble.gl is only partially integrated there is an edge case that can cause a developers webcam to be captured and saved onto their local machine. The data never leaves their local computer, and the web browser prompts the developer for permission before the webcam is active. That said, we don't want this occurring so we should fix this issue.

To Reproduce
We believe this issue occurs as default behavior of gifshot when there aren't any image frames passed in: https://github.com/yahoo/gifshot/blob/master/src/gifshot.js#L2733-L2765

Steps to reproduce the behavior:

const encoder = new GifEncoder();
encoder.start();
// no calls to encoder.add(), so no frames.
encoder.end();
// browser prompts for webcam permission
encoder.save();

Expected behavior
Hubble should use gifshot such that it never will capture from webcam.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac
  • Browser Chrome

Additional context
Add any other context about the problem here.

@chrisgervang chrisgervang added the bug Something isn't working label Oct 11, 2021
@chrisgervang chrisgervang added this to the 1.4 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant