Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time scrubber for kepler component #262

Open
chrisgervang opened this issue Oct 23, 2022 · 6 comments
Open

Time scrubber for kepler component #262

chrisgervang opened this issue Oct 23, 2022 · 6 comments
Assignees
Labels
gui User interfaces to design and iterate on animations

Comments

@chrisgervang
Copy link
Collaborator

Currently it's difficult and time consuming to preview the ending of an animation because it needs to played back in full.

A simple time scrubber in the kepler video export component would solve this issue, and allow users to see any moment in the animation before rendering.

@chrisgervang chrisgervang self-assigned this Oct 23, 2022
@akre54
Copy link
Collaborator

akre54 commented Oct 24, 2022

Yes very into this idea. Current view state should be a pure function of time and properties - we should be able to compute the values at a given timestamp easily without needing to compute everything that came before it.

Let's make this a higher priority.

@chrisgervang
Copy link
Collaborator Author

It's really easy to implement too since hubble already ships a "seek" function. This is just a UI change where the main thing to figure out is which design to go with. I had one drafted - I'll export some screens and states today for feedback.

@chrisgervang
Copy link
Collaborator Author

What do you think of this design?

Time Scrubber Proposal

@akre54
Copy link
Collaborator

akre54 commented Oct 26, 2022

I think I'd prefer a more keyframe-centric design but this is great as a starting point! Really good place to jump off from.

@chrisgervang
Copy link
Collaborator Author

Have any examples? I think I agree, but keyframe-centric design can mean so many things. I have another design approach I'll share for a one-track keyframe editor, which could be used in applications that only need one track, like a "magic keyframe" timeline discussed in #43

I think the basic time scrubber can get built within a couple days because it's so simple, whereas designing keyframe-centric sounds like a bigger effort.

@akre54
Copy link
Collaborator

akre54 commented Oct 26, 2022

See the prior art section of https://observablehq.com/@akre54/animator-lib-proposal

I'm thinking more specifically like Theater.js: https://www.theatrejs.com/docs/latest/manual/sequences

Don't disagree this is a necessary first step.

@chrisgervang chrisgervang added the gui User interfaces to design and iterate on animations label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui User interfaces to design and iterate on animations
Projects
None yet
Development

No branches or pull requests

2 participants