From 91b18b413e11e274a1cc1a97edae5f0c4914f531 Mon Sep 17 00:00:00 2001 From: chrisgervang Date: Thu, 30 Sep 2021 13:14:38 -0700 Subject: [PATCH 1/2] remove(webpack) no longer need to remove 'fs' import at compile-time --- examples/camera/webpack.config.js | 4 ---- examples/kepler-integration/webpack.config.js | 4 ---- examples/quick-start/webpack.config.js | 4 ---- examples/terrain/webpack.config.js | 4 ---- examples/trips/webpack.config.js | 4 ---- examples/worldview/webpack.config.js | 4 ---- 6 files changed, 24 deletions(-) diff --git a/examples/camera/webpack.config.js b/examples/camera/webpack.config.js index aa325880..0353ac42 100644 --- a/examples/camera/webpack.config.js +++ b/examples/camera/webpack.config.js @@ -24,10 +24,6 @@ const CONFIG = { ] }, - node: { - fs: 'empty' - }, - plugins: [ new HtmlWebpackPlugin({title: 'hubble.gl deck camera example'}), // Optional: Enables reading mapbox token from environment variable diff --git a/examples/kepler-integration/webpack.config.js b/examples/kepler-integration/webpack.config.js index 06b073c5..19f734bd 100644 --- a/examples/kepler-integration/webpack.config.js +++ b/examples/kepler-integration/webpack.config.js @@ -32,10 +32,6 @@ const CONFIG = { ] }, - node: { - fs: 'empty' - }, - plugins: [ new HtmlWebpackPlugin({title: 'hubble.gl kepler export example'}), // Optional: Enables reading mapbox token from environment variable diff --git a/examples/quick-start/webpack.config.js b/examples/quick-start/webpack.config.js index 77203022..2b1bb217 100644 --- a/examples/quick-start/webpack.config.js +++ b/examples/quick-start/webpack.config.js @@ -36,10 +36,6 @@ const CONFIG = { ] }, - node: { - fs: 'empty' - }, - plugins: [ new HtmlWebpackPlugin({title: 'hubble.gl deck quick-start example'}), // Optional: Enables reading mapbox token from environment variable diff --git a/examples/terrain/webpack.config.js b/examples/terrain/webpack.config.js index c92ccc7e..00dd9f02 100644 --- a/examples/terrain/webpack.config.js +++ b/examples/terrain/webpack.config.js @@ -24,10 +24,6 @@ const CONFIG = { ] }, - node: { - fs: 'empty' - }, - plugins: [ new HtmlWebpackPlugin({title: 'hubble.gl terrain example'}), // Optional: Enables reading mapbox token from environment variable diff --git a/examples/trips/webpack.config.js b/examples/trips/webpack.config.js index a4ec11a3..e63b03af 100644 --- a/examples/trips/webpack.config.js +++ b/examples/trips/webpack.config.js @@ -24,10 +24,6 @@ const CONFIG = { ] }, - node: { - fs: 'empty' - }, - plugins: [ new HtmlWebpackPlugin({title: 'hubble.gl deck trips example'}), // Optional: Enables reading mapbox token from environment variable diff --git a/examples/worldview/webpack.config.js b/examples/worldview/webpack.config.js index 7385ba30..04afd6c3 100644 --- a/examples/worldview/webpack.config.js +++ b/examples/worldview/webpack.config.js @@ -44,10 +44,6 @@ const CONFIG = { ] }, - node: { - fs: 'empty' - }, - plugins: [ new HtmlWebpackPlugin({title: 'hubble.gl kepler export example'}), // Optional: Enables reading mapbox token from environment variable From 56a6ab350f9bb9c9286dc1456a3429dc43287edd Mon Sep 17 00:00:00 2001 From: chrisgervang Date: Tue, 19 Oct 2021 11:03:34 -0700 Subject: [PATCH 2/2] chore(dep) upgrade webm-writer to 1.0.0 --- examples/pure-js/webpack.config.js | 4 ---- examples/standalone/webpack.config.js | 4 ---- modules/core/package.json | 2 +- scripts/bundle.config.js | 5 +---- yarn.lock | 8 ++++---- 5 files changed, 6 insertions(+), 17 deletions(-) diff --git a/examples/pure-js/webpack.config.js b/examples/pure-js/webpack.config.js index 3d51d529..8ecb367e 100644 --- a/examples/pure-js/webpack.config.js +++ b/examples/pure-js/webpack.config.js @@ -6,10 +6,6 @@ const CONFIG = { entry: { app: './app.js' - }, - - node: { - fs: 'empty' } }; diff --git a/examples/standalone/webpack.config.js b/examples/standalone/webpack.config.js index 478f2772..fe8ef927 100644 --- a/examples/standalone/webpack.config.js +++ b/examples/standalone/webpack.config.js @@ -8,10 +8,6 @@ const CONFIG = { mode: 'development', - node: { - fs: 'empty' - }, - plugins: [ new webpack.DefinePlugin({ __MAPBOX_TOKEN__: JSON.stringify(process.env.MapboxAccessToken) // eslint-disable-line diff --git a/modules/core/package.json b/modules/core/package.json index 69a7c728..84c90dab 100644 --- a/modules/core/package.json +++ b/modules/core/package.json @@ -39,7 +39,7 @@ "@math.gl/web-mercator": "^3.4.2", "downloadjs": "^1.4.7", "popmotion": "^8.6.10", - "webm-writer": "^0.2.2", + "webm-writer": "^1.0.0", "probe.gl": "^3.4.0" } } diff --git a/scripts/bundle.config.js b/scripts/bundle.config.js index 14f88aad..aaf9ff7a 100644 --- a/scripts/bundle.config.js +++ b/scripts/bundle.config.js @@ -92,10 +92,7 @@ const config = { // ,new (require('webpack-bundle-analyzer').BundleAnalyzerPlugin)() ], - node: { - fs: 'empty' - }, - + node: false, devtool: false }; diff --git a/yarn.lock b/yarn.lock index c8503c44..e1e362d5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -13586,10 +13586,10 @@ webidl-conversions@^4.0.2: resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-4.0.2.tgz#a855980b1f0b6b359ba1d5d9fb39ae941faa63ad" integrity sha512-YQ+BmxuTgd6UXZW3+ICGfyqRyHXVlD5GtQr5+qjiNW7bF0cqrzX500HVXPBOvgXb5YnzDd+h0zqyv61KUD7+Sg== -webm-writer@^0.2.2: - version "0.2.4" - resolved "https://registry.yarnpkg.com/webm-writer/-/webm-writer-0.2.4.tgz#82478e9e0e1afd0d362dcdba2d9af46c36c39e7b" - integrity sha512-3qKVGTcbpKibczZpK/t24ULi3f+gSUjHhVPILF3yURy/j0TBiECsTLa3ar/HB6WT3seX2TKnI7HpZGUNs4013g== +webm-writer@^1.0.0: + version "1.0.0" + resolved "https://registry.yarnpkg.com/webm-writer/-/webm-writer-1.0.0.tgz#78367e435dddf9bed633dd98c7ca9b36438d9943" + integrity sha512-xafP4mzUqht03HBXP0Ov2YGsxfD08uncad9fQeshYwQXrcP6Z/4uxd1IUaGKqKigFPAgaD9xb6JEKA8SXLQMLA== webpack-bundle-analyzer@^3.0.3: version "3.7.0"