Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3d-tiles] parseImplicitTiles fails to load subtree if availableLevels in the implicit tiling scheme is 1 #3193

Open
brncsk opened this issue Mar 9, 2025 · 0 comments · May be fixed by #3194
Open

[3d-tiles] parseImplicitTiles fails to load subtree if availableLevels in the implicit tiling scheme is 1 #3193

brncsk opened this issue Mar 9, 2025 · 0 comments · May be fixed by #3194

Comments

@brncsk
Copy link

brncsk commented Mar 9, 2025

The condition in the line below fails to account for the case when maximumLevel is 0:

loaders.gl/modules/3d-tiles/src/lib/parsers/helpers/parse-3d-implicit-tiles.ts

Line 139 in d74df44

if (!maximumLevel) {

I'm admittedly no 3d tiles expert but I guess this should be !Number.isFinite(maximumLevel) in order to cater for tilesets where the implicit tiling scheme defines a single level (copy-pasting the following from a Cesium Tileset we're using):

    "implicitTiling": {
      "subdivisionScheme": "OCTREE",
      "subtreeLevels": 5,
      "availableLevels": 1,
      "subtrees": { "uri": "subtrees/{level}/{x}/{y}/{z}.subtree" }
    },

maximumLevel is being set to 0 here in normalizeImplicitTileHeaders():

loaders.gl/modules/3d-tiles/src/lib/parsers/parse-3d-tile-header.ts

Line 226 in d74df44

maximumLevel: Number.isFinite(availableLevels) ? availableLevels - 1 : maximumLevel,

@brncsk brncsk changed the title [3d-tiles] parseImplicitTiles fails to load subtree if maximumLevel is 0 [3d-tiles] parseImplicitTiles fails to load subtree if availableLevels in the implicit tiling scheme is 1 Mar 9, 2025
@brncsk brncsk linked a pull request Mar 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brncsk