fix: change transformation setters call order #2391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of setters in
applyViewStateToTransform
has a side effect which leads to wrong camera transformation. In a case ofmap.jumpTo({center: [12,34], zoom: 15})
from{center: [0,0], zoom: 0}
the current order of setters in case of maplibre-gl leads to the following:But expected would be to have
{center: [12,34], zoom: 15}
instead of{center: [12,0], zoom: 15}
.The changed order leads to the following setters sequence