Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with running multiple tests after upate to version 1.5.8 #19

Open
ussuritiger opened this issue May 25, 2015 · 9 comments
Open

Comments

@ussuritiger
Copy link

Hi guys, first of all thank you for moving Sinon and Chai to the separate modules. After I've updated entire plugin up to the version 1.5.8 and adjusted dependencies in my Gruntfile.js with Sinon and Chai, I've got another problem. When I run grunt I get output that the tests in the first file are successfully passed, then there is some delaying while processing the next file and then I get this:

Test tests/.../Alert.test.js

PhantomJS threw an error:ERROR

0 [ '' ]
Warning: PhantomJS exited unexpectedly with exit code null. Use --force to continue.

Aborted due to warnings.

Before I've updated the grunt-js-test plugin to the version 1.5.8 all the tests were processed without any problem. Do you know what can be wrong?

Thanks.

@texclayton
Copy link
Collaborator

Could it be the same issue reported as gruntjs/grunt-lib-phantomjs#78?

@victorquinn
Copy link
Contributor

I'm having this same issue with Chance, any updates here?

Seems it runs the first test file then dies before loading the second test file. I've tried rearranging them to confirm it's not an issue with that particular test file and it's not.

Same happens on 1.5.7 as well.

victorquinn added a commit to victorquinn/grunt-js-test that referenced this issue Sep 11, 2015
@texclayton
Copy link
Collaborator

Did bumping the version of grunt-lib-phantomjs to 0.7.1 fix your problem?

@victorquinn
Copy link
Contributor

Sorry, should have updated here, nope that didn't help.

@texclayton
Copy link
Collaborator

I haven't been able to reproduce the issue.

Do you have any more details? A stack trace? Can you debug it with 'node-debug grunt js-test'?
Do the tests run fine when you run with the server option (js-test-server)?

@victorquinn
Copy link
Contributor

No stack trace, I found it easily replicable by doing the following:

  1. Clone the latest version of Chance git clone https://github.com/victorquinn/chancejs.git
  2. Edit the package.json changing the version of grunt-js-test from my git fork to 1.5.8
  3. Run npm install
  4. Run bower install
  5. Run grunt test-ci which runs js-test

You'll notice the first test file runs, then it hangs.

I noticed if I disable coverage in the grunt-js-test options by changing this line from true to false, it runs fine and doesn't hang.

@victorquinn
Copy link
Contributor

Here's the output of grunt test-ci --verbose:

https://gist.github.com/victorquinn/525172e3ab4b3ab6a4a5

It finds all the test files, runs the first one, then hangs.

@texclayton
Copy link
Collaborator

I can reproduce it with your listed steps, but I'm not sure why PhantomJS is timing out.

@marcstober
Copy link

Does pull request #20 fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants