Add configuration for the monitor health check. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… documentation. Use the fully qualified app name for all the resources
betabandido
requested changes
Oct 29, 2019
betabandido
requested changes
Oct 29, 2019
README.md
Outdated
| newrelic_fully_qualified_app_name = "Team/PRD/App" | ||
| service_healthcheck_url = "https://your-service-url.com" | ||
| synthetics_monitor_health_endpoint_url = "https://your-service-url.com" |
| status = "ENABLED" | ||
| locations = ["AWS_US_EAST_1", "AWS_US_WEST_1", "AWS_EU_WEST_1", "AWS_EU_WEST_3", "AWS_AP_NORTHEAST_1", "AWS_AP_SOUTHEAST_2"] | ||
| bypass_head_request = var.synthetics_monitor_bypass_head_request |
There was a problem hiding this comment.
Not aligned. Easy to solve in VS code: cmd+shift+P then Format Document.
Actually, let's use this to improve locations too. I would place each location on a different line:
locations = [
"AWS_US_EAST_1",
"AWS_US_WEST_1",
...
]
There was a problem hiding this comment.
Thank you, I was not aware of the Format Document action
test/test.tf
Outdated
| @@ -4,11 +4,10 @@ provider "newrelic" { | |||
|
|
|||
| module "newrelic_monitoring" { | |||
| source = "../" | |||
|
|
|||
| newrelic_app_name = var.newrelic_app_name | |||
|
|
|||
added 3 commits
October 30, 2019 10:07
betabandido
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for themonitor health check.
Add defaults to variables documentation.
Use the fully qualified app name for all the resources