Skip to content

Commit

Permalink
Revert Fields and bindLocations equality check
Browse files Browse the repository at this point in the history
It failed for some materializations

Signed-off-by: Matt Lord <[email protected]>
  • Loading branch information
mattlord committed Nov 11, 2024
1 parent f0f61db commit 6ff6f84
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ func valsEqual(v1, v2 sqltypes.Value) bool {
func (tp *TablePlan) appendFromRow(buf *bytes2.Buffer, row *querypb.Row) error {
bindLocations := tp.BulkInsertValues.BindLocations()
usedFieldCnt := len(tp.Fields) - len(tp.FieldsToSkip)
if usedFieldCnt != len(bindLocations) {
if usedFieldCnt < len(bindLocations) {
return vterrors.Errorf(vtrpcpb.Code_INTERNAL, "wrong number of fields: got %d fields for %d bind locations",
usedFieldCnt, len(bindLocations))
}
Expand Down

0 comments on commit 6ff6f84

Please sign in to comment.