Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing sample data #3825

Open
chenejac opened this issue Feb 20, 2023 · 2 comments · May be fixed by vivo-project/sample-data#9
Open

Reorganizing sample data #3825

chenejac opened this issue Feb 20, 2023 · 2 comments · May be fixed by vivo-project/sample-data#9
Assignees
Milestone

Comments

@chenejac
Copy link
Contributor

chenejac commented Feb 20, 2023

Is your feature request related to a problem? Please describe.
Standardization of the structure of sample data is needed. It is not clear at the moment what should be done with content of subdirectories of https://github.com/vivo-project/sample-data, i.e. it is not clear where it should be copied. Moreover, some of the content is zipped as archive.

Describe the solution you'd like

  • Readme file of the repository should briefly introduced which subdirectories/sample data are there
  • Each subdirectory should represent a sample data (we have three at the moment - OpenVIVO sample data, UF sample data, and small i18n sample data for testing VIVO)
  • Each subdirectory should include readme file and content which should be copied to [VIVO_HOME]/rdf directory
  • Readme file of each subdirectory should describe details of sample data, e.g. https://github.com/vivo-project/sample-data/blob/main/uf/README.md
  • Besides copying of sample data directory to [VIVO_HOME]/rdf directory, the readme file should also describe process of ingesting sample data through user interface, if it is possible and if there is any specificity of that
  • Sample data subdirectory should contain data which are not zipped, and triples should be decoupled per files in such a way that one file might have maximally 1M triplets.
@chenejac chenejac converted this from a draft issue Feb 20, 2023
@chenejac chenejac moved this from Needs Triage to Todo in Semantic web features improvements Feb 20, 2023
@chenejac chenejac added High and removed High labels Feb 20, 2023
@michel-heon
Copy link
Member

@chenejac
Hello
Is it possible to add a tag to the current code. This tag is necessary to ensure the stability of the code I develop for #3823 (Testing performance of external graph usage) since the sample is directly loaded by the pom file. Code that could be a contribution to the current task.
See line 52 of https://github.com/michel-heon/VIVO/blob/semantic-web/home/pom.xml where the url should be perenalized from a label and not on 'main'.
Remember that the structure of this directory will change in the near future and that necessarily this URL will no longer exist thus creating chaos
I propose the label
sample-1.14.0
Please do this quickly because it is currently a blocker for 3823

@chenejac chenejac self-assigned this Feb 24, 2023
@chenejac chenejac moved this from Todo to In review in Semantic web features improvements Feb 27, 2023
@chenejac
Copy link
Contributor Author

@chenejac Hello Is it possible to add a tag to the current code. This tag is necessary to ensure the stability of the code I develop for #3823 (Testing performance of external graph usage) since the sample is directly loaded by the pom file. Code that could be a contribution to the current task. See line 52 of https://github.com/michel-heon/VIVO/blob/semantic-web/home/pom.xml where the url should be perenalized from a label and not on 'main'. Remember that the structure of this directory will change in the near future and that necessarily this URL will no longer exist thus creating chaos I propose the label sample-1.14.0 Please do this quickly because it is currently a blocker for 3823

Done, https://github.com/vivo-project/sample-data/releases/tag/sample-data-0.2

@ghost ghost linked a pull request Feb 28, 2023 that will close this issue
@chenejac chenejac added this to the sample-data-2 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

2 participants