-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing performance of external graph usage - performance patch #377
Conversation
java 8. It will abort the compilation if the Java context is version 8
return to 1.13.1
Return to 1.13.1
Return to 1.13.1
Return 1.13.1
Return 1.13.1
Return 1.13.1
fixed message printing bugs on previous version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments, but in general I suggest to clean up the PR first.
<build> | ||
<plugins> | ||
<plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note: please remove changes not specific to this PR. There are a lot of modifications from other PR that aren't necessary here.
* I suggest to put the assignment of this variable in runtime.properties | ||
* | ||
*/ | ||
private static final int INDIVIDUALS_PER_PAGE = 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it should be in runtime.properties or it there could be some other place to configure that, but changing default value for all Vitro and VIVO users doesn't look good to me.
@@ -79,864 +79,863 @@ | |||
*/ | |||
public class RDFServiceSparql extends RDFServiceImpl implements RDFService { | |||
|
|||
private static final Log log = LogFactory.getLog(RDFServiceImpl.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more general notice: please revert formatting changes for all unnecessary changes in this PR. Not only does this make the review much more difficult, but it could also introduce unnecessary merge conflicts with other PRs.
superseded by #378 |
Testing performance of external graph usage:
What does this pull request do?
This PR partially solves the network latency problem in the communication between a VIVO instance in server-less mode and its remote triples server.
What's new?
Four classes are affected by this PR:
- RDFServiceSparql - Make the connection test more generic
- JsonServlet - Decrease the number of individuals called per page
- IndividualListController - Unify the individual name value to be processed per page as defined in JsonServlet
- GetRenderedSearchIndividualsByVClass - Set the addShortViewRenderings method to parallel processing mode
How should this be tested?
Prerequisites
Note: it is important that both servers (VIVO & TripleStore) are in their own computational instance (VM) to observe network latency during SPARQL calls
Configuration
:application :hasContentTripleSource :sparqlContentTripleSource ;
and the contents of `sparqlContentTripleSourceHere is a sample configuration for AWS-NEPTUNE for our development
Compilation and execution
Additional Notes:
For more details on how to perform more formal testing, please refer to the outcome definition
Interested parties
@chenejac