Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not all code paths in device.Open close the underline device on error #55

Open
rgl opened this issue Sep 2, 2023 · 1 comment
Open

not all code paths in device.Open close the underline device on error #55

rgl opened this issue Sep 2, 2023 · 1 comment

Comments

@rgl
Copy link

rgl commented Sep 2, 2023

Not all the code paths call v4l2.CloseDevice when there is an error at:

https://github.com/vladimirvivien/go4vl/blob/v0.0.5/device/device.go#L28-L116

All the return statements that return an error should call v4l2.CloseDevice.
@vladimirvivien
Copy link
Owner

Thank you for this @rgl . Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgl @vladimirvivien