Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree_sitter_v] Support for mut is clause #77

Merged
merged 4 commits into from
Mar 31, 2024
Merged

[tree_sitter_v] Support for mut is clause #77

merged 4 commits into from
Mar 31, 2024

Conversation

Lycs-D
Copy link
Contributor

@Lycs-D Lycs-D commented Mar 30, 2024

ttytm
ttytm approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@ttytm ttytm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully seeing through why the is_expression - that has already an optional mutability_modifier on its own - does not work directly like other expressions do. But making this sequence with the additional hard coded preceding 'mut' does work so LGTM, thank you!.

@ttytm
Copy link
Member

ttytm commented Mar 31, 2024

Rebased over main. Pushed a tiny update to recognizance is clauses with and without mut in for loops uniformly.

@ttytm ttytm merged commit bb6ca96 into vlang:main Mar 31, 2024
14 checks passed
@Lycs-D Lycs-D deleted the fix_for_mut_is branch March 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttytm ttytm ttytm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tree_sitter fails to recognize for mut is clauses
2 participants
@Lycs-D @ttytm