Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated jump target address with oso (0x66) #126

Open
rfalke opened this issue Nov 22, 2017 · 2 comments · May be fixed by #128
Open

Truncated jump target address with oso (0x66) #126

rfalke opened this issue Nov 22, 2017 · 2 comments · May be fixed by #128

Comments

@rfalke
Copy link

rfalke commented Nov 22, 2017

In

$ echo "66 70 00" | ./udcli/udcli -o 19730f -x
000000000019730f 667000           o16 jo 0x7312

I would expect the target address as 0x197311. See below:

$ echo "70 00" | ./udcli/udcli -o 19730f -x
000000000019730f 7000             jo 0x197311
@skirsten
Copy link

skirsten commented Feb 8, 2018

This happens because the address gets truncated for some reason in the ud_syn_rel_target function.
I don't know if this is expected (why has u->opr_mode even anything to say in this context ?) but it renders the project completely useless. I removed this truncation but still this has greatly reduced my confidence in the project.

@Fonger
Copy link

Fonger commented May 7, 2018

@skirsten @rfalke
I create a pull request to resolve this issue.
Actually, the problem is the definition of docs/x86/optable.xml

back in 2013, there was the same bug in jmp instruction and was fixed the same way by @vmt at 2360d9c.
My pull request #128 fix all conditional jump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants