Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

URI parsing syntax does not permit for specifying AD Domain. [RVC 1.7.0][2012-10-02] #61

Open
Logos01 opened this issue Oct 2, 2012 · 7 comments

Comments

@Logos01
Copy link

Logos01 commented Oct 2, 2012

The current authentication model of RVC does not permit for logins for any vCenter user that is required to declare their AD Domain in order to successfully authenticate against the server.

[ RFC2396 -- https://www.ietf.org/rfc/rfc2396.txt -- Uniform Resource Identifiers (URI): Generic Syntax ] seems to be the syntax by which the login credentials given to RVC are parsed, but they do not permit for the syntax of "DOMAIN\user@hostname"

Without this functionality I have no capability to even attempt a login against my credentials for my vCenter server.

@Logos01
Copy link
Author

Logos01 commented Oct 2, 2012

Modifying line 37 in rvc-1.7.0/lib/rvc/modules/vim.rb to be:
username = URI.decode(uri.user) || ENV['RBVMOMI_USER']

Allows for the use of "%5C" in lieu of the plaintext backslash or escaped backslash in prompt as a work-around to enable authentication with AD Domain declared.

@StrangeWill
Copy link

I was the one that helped Logos01 by poking at this, I'll look into making a pull request that properly escapes/unescapes connection data on the vim schema hopefully later today.

@cdickmann
Copy link
Contributor

Thanks for working on a patch. Please include an array of unit tests with this change to make sure the new implementation is strictly better than the old one.

@patrobinson
Copy link

Although it's nice to just set the env this commit appears to fix it codemonkeyjohn@001e52c but still hasn't been merged?

@wmotti
Copy link

wmotti commented Dec 16, 2014

Any news?

@StrangeWill
Copy link

I've had a pull request open for two years that fixes this, bug VMware at this point. :\

@ilosamart
Copy link

It seems that VMWare abandoned this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants