Add pr test jobs #9
Conversation
Add jenkins jobs for vic and vic-product PR testing. These jobs are aimed to verify scenario test code. Start selenium nodes according to parallel executor number to avoid creating idle nodes. Keep secret keywords for troubleshooting.
DanielXiao
force-pushed
the
topic/jenkins
branch
from
4e2d84b to
82949d6
Compare
| - git: | ||
| url: 'https://github.com/vmware/vic-tools' | ||
| branches: | ||
| - 'master' | ||
| basedir: 'vic-tools' | ||
| - git: |
There was a problem hiding this comment.
What is the significance of this reordering?
There was a problem hiding this comment.
Environment variable GIT_COMMIT will be set the the commit id of the last repo. Commit id of vic-tools and vic-internal is useless.
| description: 'This is a parameterized build for verifying your test code in a PR' | ||
| node: '{node}' | ||
| parameters: |
There was a problem hiding this comment.
Is there any way to deduplicate these parameters with the other jobs? It seems like we'd want to keep most of them consistent.
There was a problem hiding this comment.
Yes. We can improve this later.
| - requester | ||
| subject: 'vmware/{repo} PR Testing - ${{TEST_BRANCH}}' | ||
| body: | |
There was a problem hiding this comment.
Could this message include more information about the test run? If you're running a few tests at the same time, it seems like figuring out which one an email is talking about might require actually opening Jenkins
There was a problem hiding this comment.
TEST_BRANCH is PR number, what other information do you think is better to have in the email?
| defaults: 'pr-tests' | ||
| builders: | ||
| - shell: | |
There was a problem hiding this comment.
Is there any way to deduplicate this with other jobs?
There was a problem hiding this comment.
I don't know how to deduplicate this with other jobs.
| @@ -125,7 +125,7 @@ pushd vic | |||
| echo "Tarball extraction passed, Running nightlies test.." | |||
| fi | |||
|
|
|||
| pabot --processes ${PARALLEL_JOBS} --removekeywords TAG:secret ${excludes} --variable ESX_VERSION:"${ESX_BUILD}" --variable VC_VERSION:"${VC_BUILD}" -d report "${testcases[@]}" | |||
| pabot --processes ${PARALLEL_JOBS} ${excludes} --variable ESX_VERSION:"${ESX_BUILD}" --variable VC_VERSION:"${VC_BUILD}" -d report "${testcases[@]}" | |||
There was a problem hiding this comment.
I don't think we want to make this change; removing secret information from logs is important.
There was a problem hiding this comment.
OK. I will revert it back, but it is really difficulty for troubleshooting without logging them.
Add jenkins jobs for vic and vic-product PR testing. These
jobs are aimed to verify scenario test code.
Start selenium nodes according to parallel executor number
to avoid creating idle nodes.