[velero] Improve docs and add examples

[MaxymVlasov]

Special notes for your reviewer:

I also can add Terraform 0.13 code for setup AWS and vSphere from zero, but not sure that it should be here.

P.S. Sad, but helm-chart not be used for up Velero 1.5.1 yet, so examples based on 1.4.2.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [velero])

[jenting]

I'm sure not is it good to put an example in the released helm chart 🤔 or would it be good to add the examples to the README.
What are other reviewers think? @nrb @carlisia @ashish-amarnath @cpanato

[MaxymVlasov]

Looks like the AWS plugin not support Velero v1.5 yet, so examples stay for v1.4.

[nrb]

Looks like the AWS plugin not support Velero v1.5 yet, so examples stay for v1.4.

It does, I'll update the compatibility chart.

[MaxymVlasov]

Okay, maybe it was another issue, because I try up and run 1.5.2 yesterday, after full removal of 1.4.2. but velero version not found Velero Server version at all, when Velero pod works fine and schedule triggered backup.

All that I changed - chart version to latest and tag to 1.5.2. All AWS infra was recreated from scratch, namespace deleted and recreated, velero client binary updated too.

[carlisia]

I love the intention of this PR and some things are useful, but replicating the documentation in this repo creates a maintenance burden because we will need to keep it in sync with the original documentation, and I'm not sure it buys us much. I'll take a closer look at this today.

[mkilchhofer]

I'm sure not is it good to put an example in the released helm chart 🤔 or would it be good to add the examples to the README.

When the examples directory is ignored from packaging by adding it to the .helmignore file, this would be okay.

[MaxymVlasov]

Added examples/ to .helmignore

[jenting]

I love the intention of this PR and some things are useful, but replicating the documentation in this repo creates a maintenance burden because we will need to keep it in sync with the original documentation, and I'm not sure it buys us much. I'll take a closer look at this today.

@carlisia,
I'd prefer we could add these examples to https://github.com/vmware-tanzu/helm-charts/tree/main/charts/velero/ci
So, we could make sure these examples work well by CI testing.

[MaxymVlasov]

Well, I think now it's completely outdated so there is no sense to keep that PR open