From f3f6635f4da787a8831c13b4fb08206c5c5f4e89 Mon Sep 17 00:00:00 2001 From: Shubham Pampattiwar Date: Wed, 24 Jan 2024 23:06:44 -0800 Subject: [PATCH] fix vsc backup plugin progress method to not fail on temporary errors Signed-off-by: Shubham Pampattiwar --- internal/backup/volumesnapshotcontent_action.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/backup/volumesnapshotcontent_action.go b/internal/backup/volumesnapshotcontent_action.go index 2298ba00..99d9e832 100644 --- a/internal/backup/volumesnapshotcontent_action.go +++ b/internal/backup/volumesnapshotcontent_action.go @@ -153,10 +153,11 @@ func (p *VolumeSnapshotContentBackupItemAction) Progress(operationID string, bac if boolptr.IsSetToTrue(vsc.Status.ReadyToUse) { progress.Completed = true } else if vsc.Status.Error != nil { - progress.Completed = true + errorMessage := "" if vsc.Status.Error.Message != nil { - progress.Err = *vsc.Status.Error.Message + errorMessage = *vsc.Status.Error.Message } + p.Log.Warnf("VolumeSnapshotContent has a temporary error %s. SnapshotContent controller will retry later.", errorMessage) } return progress, nil