inconsistent log output format

[seankhliao]

What steps did you take and what happened:

k8s.io/client-go writes out logs through k8s.io/klog{,/v2} in a different format than the rest of the application (logfmt or json) making it more difficult to parse, example:

time="2021-03-09T08:12:51Z" level=info msg="No backup locations were ready to be verified" controller=backupstoragelocation logSource="pkg/controller/backupstoragelocation_controller.go:120"
I0309 08:13:16.387907       1 request.go:621] Throttling request took 1.058190834s, request: GET:https://10.250.0.1:443/apis/autoscaling.k8s.io/v1?timeout=32s
time="2021-03-09T08:13:50Z" level=info msg="Checking for existing backup locations ready to be verified; there needs to be at least 1 backup location available" controller=backupstoragelocation logSource="pkg/controller/backupstoragelocation_controller.go:58"

What did you expect to happen:

logs output in a consistent format

Anything else you would like to add:

Environment:

• Velero version (use velero version): 1.5.3

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "I would like to see this bug fixed as soon as possible"
• 👎 for "There are more important bugs to focus on right now"

requires: #8442

[kaovilai]

Velero need to bump

velero/go.mod

Line 55 in 9f0026d

k8s.io/client-go v0.30.5

to v0.31.0 or above which contains kubernetes/client-go@75fea27 which will allow us to set klog.SetLogger() which should solve this problem.

some examples

[kaovilai]

My team's goal is to enable all logs to be in json formatting which requirement is a subset that aligns with this issue IMO.

[kaovilai]

velero/pkg/util/logging/format_flag.go

Lines 24 to 26 in 9f0026d

	FormatText Format = "text"
	FormatJSON Format = "json"
	defaultValue Format = FormatText

these flags should apply to logs coming from client-go.

[reasonerjt]

@kaovilai let me clarify so after this is resolved by default the log will still be text-format, right?

[kaovilai]

Should still be text by default yes