Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero backup create --from-schedule labels backup in local time #4279

Closed
jglick opened this issue Oct 25, 2021 · 1 comment · Fixed by #4353
Closed

velero backup create --from-schedule labels backup in local time #4279

jglick opened this issue Oct 25, 2021 · 1 comment · Fixed by #4353
Assignees
Labels
Bug Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start!

Comments

@jglick
Copy link

jglick commented Oct 25, 2021

What steps did you take:

velero create schedule xxx '--schedule=@every 15m' --ttl 1h
# a couple hours later…
velero backup create --from-schedule xxx
velero get backup

What did you expect to happen:

To see a list of backups with the newly manually scheduled backup at the top, all with names based on UTC time of backup creation.

What happened instead:

NAME                 STATUS            ERRORS   WARNINGS   CREATED                         EXPIRES   STORAGE LOCATION   SELECTOR
xxx-20211025151320   PartiallyFailed   12       51         2021-10-25 11:13:20 -0400 EDT   48m       default            <none>
xxx-20211025145809   PartiallyFailed   34       0          2021-10-25 10:58:09 -0400 EDT   33m       default            <none>
xxx-20211025144309   PartiallyFailed   31       0          2021-10-25 10:43:09 -0400 EDT   18m       default            <none>
xxx-20211025142809   PartiallyFailed   21       0          2021-10-25 10:28:09 -0400 EDT   3m        default            <none>
xxx-20211025141309   Deleting          25       0          2021-10-25 10:13:09 -0400 EDT   11m ago   default            <none>
xxx-20211025112340   InProgress        0        0          2021-10-25 11:23:40 -0400 EDT   58m       default            <none>

You can see that the in-progress backup I just made is given a name based on the local time on my computer, whereas the regular backups made by the server process are labeled in UTC. Thus the manually created backup is displayed in an unnatural sort order.

Environment:

Client v1.7.0; server locally patched but recent (from #4242). EKS v1.21.2.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@dsu-igeek dsu-igeek added Bug Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! labels Nov 2, 2021
@jglick
Copy link
Author

jglick commented Nov 3, 2021

Workaround:

TZ=UTC velero backup create --from-schedule xxx

@blackpiglet blackpiglet self-assigned this Nov 8, 2021
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 15, 2021
…mezone.

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Singed-off-by: Xun Jiang <[email protected]>
Signed-off-by: jxun <[email protected]>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 16, 2021
…mezone.

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Singed-off-by: Xun Jiang <[email protected]>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 16, 2021
…mezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 16, 2021
…mezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 16, 2021
…mezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 16, 2021
…mezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 16, 2021
…mezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>
zubron pushed a commit that referenced this issue Nov 17, 2021
#4353)

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix #4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix #4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix #4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* modify changelog description

Reword the changelog description according to comments.

Signed-off-by: Xun Jiang <[email protected]>

Co-authored-by: jxun <[email protected]>
Co-authored-by: Xun Jiang <[email protected]>
qiuming-best pushed a commit to qiuming-best/velero that referenced this issue Nov 22, 2021
vmware-tanzu#4353)

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* modify changelog description

Reword the changelog description according to comments.

Signed-off-by: Xun Jiang <[email protected]>

Co-authored-by: jxun <[email protected]>
Co-authored-by: Xun Jiang <[email protected]>
qiuming-best pushed a commit to qiuming-best/velero that referenced this issue Nov 22, 2021
vmware-tanzu#4353)

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* modify changelog description

Reword the changelog description according to comments.

Signed-off-by: Xun Jiang <[email protected]>

Co-authored-by: jxun <[email protected]>
Co-authored-by: Xun Jiang <[email protected]>
danfengliu pushed a commit to danfengliu/velero that referenced this issue Jan 25, 2022
vmware-tanzu#4353)

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* modify changelog description

Reword the changelog description according to comments.

Signed-off-by: Xun Jiang <[email protected]>

Co-authored-by: jxun <[email protected]>
Co-authored-by: Xun Jiang <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this issue May 14, 2022
vmware-tanzu#4353)

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* fix: modify generated from schedule's backup name timestamp to UTC timezone

fix vmware-tanzu#4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.

Signed-off-by: Xun Jiang <[email protected]>

* modify changelog description

Reword the changelog description according to comments.

Signed-off-by: Xun Jiang <[email protected]>

Co-authored-by: jxun <[email protected]>
Co-authored-by: Xun Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start!
Projects
None yet
3 participants