Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installOption terminationGracePeriodSeconds #4857

Closed
kaovilai opened this issue Apr 25, 2022 · 6 comments
Closed

installOption terminationGracePeriodSeconds #4857

kaovilai opened this issue Apr 25, 2022 · 6 comments

Comments

@kaovilai
Copy link
Member

kaovilai commented Apr 25, 2022

Describe the problem/challenge you have
[A description of the current limitation/problem/challenge that you are experiencing.]
People with performance issues may want to fiddle with customizable terminationGracePeriodSeconds of the Velero Deployment.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
velero CLI install flag velero install --terminationGracePeriodSeconds=50
Implement a new pkg/install/deployment.go/podTemplateOption

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@ywk253100
Copy link
Contributor

Could you describe the requirement in more detail so that we can better understand it?

@kaovilai
Copy link
Member Author

@ywk253100 added some more detail.
Does that help?

@ywk253100
Copy link
Contributor

ywk253100 commented Apr 27, 2022

I mean to describe why users need this config? Is it used to make sure all in-progress backing up/restoring/other tasks completed before exiting?

@kaovilai
Copy link
Member Author

@birsanv wanted the ability to configure this for performance testing.

Is it used to make sure all in-progress backing up/restoring/other tasks completed before exiting?

yes.

@kaovilai
Copy link
Member Author

Could be achieved with cpu/mem bump generally but this is another option a user can play with.

@kaovilai
Copy link
Member Author

kaovilai commented Feb 9, 2024

Circling back on this, user was able to resolve issue via increasing CPU request limit so closing this for now.

@kaovilai kaovilai closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants