-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable unused-parameter from revive #8625
base: main
Are you sure you want to change the base?
Conversation
/kind changelog-not-required |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8625 +/- ##
==========================================
+ Coverage 59.33% 59.34% +0.01%
==========================================
Files 370 370
Lines 39932 39932
==========================================
+ Hits 23692 23697 +5
+ Misses 14744 14739 -5
Partials 1496 1496 ☔ View full report in Codecov by Sentry. |
0ffabfd
to
3405568
Compare
79d8659
to
1e9464a
Compare
4552df2
to
1edf3b7
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
1edf3b7
to
327ec28
Compare
Thanks for the PR! I believe this rule has some negative effects. for example, when you change "func f(BackupID string)" to "func f(_ string)", it makes the future change a little more difficult. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm blocking this PR until the maintainers reach agreement regarding whether the rule should be enforced.
Thank you for contributing to Velero!
Please add a summary of your change
enable and fixes unused-parameter rule from revive
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.