Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish boringcrypto image #8412

Closed
wants to merge 1 commit into from
Closed

Conversation

kaovilai
Copy link
Member

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Provides a community boringcrypto enabled container images.

No promises of complaince with FIPS are made.

Does your change fix a particular issue?

Fixes #7649

Please indicate you've done the following:

Copy link
Member Author

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also may need changes in .github/workflows/push-builder.yml

Just opening this for initial review of required changes and discussion for closing issue.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.97%. Comparing base (dacd5ef) to head (7882a5e).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
+ Coverage   58.94%   58.97%   +0.03%     
==========================================
  Files         367      368       +1     
  Lines       38926    38973      +47     
==========================================
+ Hits        22945    22986      +41     
- Misses      14518    14524       +6     
  Partials     1463     1463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kaovilai kaovilai force-pushed the boringcrypto branch 10 times, most recently from 895bb57 to 7882a5e Compare November 18, 2024 16:09
@kaovilai kaovilai marked this pull request as ready for review November 18, 2024 16:10
@kaovilai kaovilai marked this pull request as draft November 18, 2024 19:43
Copy link
Member Author

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need further changes to go toolset used that has fips enabled.
In addition, all the fips enabled go CLI I have seen are linux/windows and exclude darwin.
This will complicate all-build and other related make targets.

Signed-off-by: Tiger Kaovilai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Please make FIPS 140-2 compliant images available
1 participant