Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8433: add third party labels to data mover pods when the same labels exist in node-agent pods #8487

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Dec 5, 2024

Fix issue #8433, add third party labels to data mover pods when the same labels exist in node-agent pods

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 59.04%. Comparing base (04d6c79) to head (3ce6838).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/data_upload_controller.go 36.36% 5 Missing and 2 partials ⚠️
pkg/controller/data_download_controller.go 25.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8487      +/-   ##
==========================================
+ Coverage   59.02%   59.04%   +0.01%     
==========================================
  Files         369      369              
  Lines       39056    39104      +48     
==========================================
+ Hits        23052    23088      +36     
- Misses      14542    14553      +11     
- Partials     1462     1463       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 5, 2024 11:21
@github-actions github-actions bot requested review from sseago and ywk253100 December 5, 2024 11:22
sseago
sseago previously approved these changes Dec 5, 2024
@Lyndon-Li Lyndon-Li changed the title Issue 8433: add ask label to data mover pods Issue 8433: add aks label to data mover pods Dec 5, 2024
changelogs/unreleased/8487-Lyndon-Li Outdated Show resolved Hide resolved
@kaovilai kaovilai linked an issue Dec 5, 2024 that may be closed by this pull request
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-8433-data-mover-pod-label-for-aks branch from 9af57ab to d914702 Compare December 6, 2024 05:59
@Lyndon-Li Lyndon-Li requested a review from kaovilai December 6, 2024 05:59
@Lyndon-Li Lyndon-Li requested review from ywk253100 and sseago December 6, 2024 10:22
sseago
sseago previously approved these changes Dec 6, 2024
kaovilai
kaovilai previously approved these changes Dec 6, 2024
changelogs/unreleased/8487-Lyndon-Li Outdated Show resolved Hide resolved
@Lyndon-Li Lyndon-Li changed the title Issue 8433: add aks label to data mover pods Issue 8433: add third party labels to data mover pods when the same labels exist in node-agent pods Dec 9, 2024
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-8433-data-mover-pod-label-for-aks branch from 487337c to 26d6107 Compare December 9, 2024 03:09
blackpiglet
blackpiglet previously approved these changes Dec 9, 2024
@Lyndon-Li Lyndon-Li requested a review from ywk253100 December 9, 2024 09:21
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-8433-data-mover-pod-label-for-aks branch from 26d6107 to 04cc78d Compare December 9, 2024 10:40
@Lyndon-Li Lyndon-Li requested a review from blackpiglet December 9, 2024 10:42
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-8433-data-mover-pod-label-for-aks branch from 04cc78d to 443e360 Compare December 9, 2024 10:57
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-8433-data-mover-pod-label-for-aks branch from 443e360 to 3ce6838 Compare December 9, 2024 11:46
@sseago sseago merged commit a1cf952 into vmware-tanzu:main Dec 9, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data mover not working with velero 1.15.0 and Azure Workload Identity
6 participants