[WIP] Add support for Edge transport nodes which were created externally #1473
Conversation
ksamoray
force-pushed
the
edge_ova_create
branch
from
aef02f1 to
8bf7432
Compare
ksamoray
force-pushed
the
edge_ova_create
branch
2 times, most recently
from
e20b1dc to
d9d4d11
Compare
| Optional: true, | ||
| Computed: true, | ||
| Description: "Unique Id of the fabric node", | ||
| }, |
There was a problem hiding this comment.
This is probably a bad idea, but I'll suggest it anyway.
As this resource is not generated, we do not have to fully respect the NSX API schema.
Perhaps we can move node_id in deployment_config and specify that it conflictsWith vm_deployment_config?
There was a problem hiding this comment.
deployment_config block contains stuff which is related to the Edge VM deployment: also attributes which are outside the vm_deployment_config block is related, e.g form_factor. Also node_user_settings is related.
And as these are required for a non-pre-deployed, we'll have to change those to optional for pre-deployed edges.
In fact I think that it's a good idea to mark deployment_config and node_id as conflicting.
| fail. | ||
| So the provider will ignore node_deployment_info properties when node_id has a value - which would mean that | ||
| this edge appliance was created externally. | ||
| */ |
There was a problem hiding this comment.
It might be helpful to also add a log statement here for debugging purposes.
e.g: "nodeID not specified, will deploy edge using values in deploymentConfig"
| var nodeDeploymentInfo *data.StructValue | ||
| if nodeID == "" { | ||
| /* | ||
| node_id attribute conflicts with node_deployment_info. As node_deployment_info is a complex object which has |
There was a problem hiding this comment.
Could you please clarify - even when specifying node_id, user still needs to populate node_deployment_info? What properties are needed?
I don't think node_deployment_info is Computed
There was a problem hiding this comment.
The resource has no node_deployment_info attribute as it's not implementing the entire API, as host nodes are created with policy API. Relevant node_deployment_info attributes are placed under deployment_config, and directly under the resource root.
I've set these attributes as conflicting with node_id.
ksamoray
force-pushed
the
edge_ova_create
branch
from
d9d4d11 to
039889c
Compare
| @@ -725,6 +745,16 @@ func resourceNsxtEdgeTransportNodeCreate(d *schema.ResourceData, m interface{}) | |||
| connector := getPolicyConnector(m) | |||
| client := nsx.NewTransportNodesClient(connector) | |||
|
|
|||
| nodeID := d.Get("node_id").(string) | |||
| if nodeID != "" { | |||
| _, err := client.Get(nodeID) | |||
There was a problem hiding this comment.
We don't need to set revision/other computed properties here?
annakhm
changed the title
|
Keeping this PR in 3.8.0 milestone as we're almost done with the review process. |
Normally users create Edge Transport Nodes within NSX, which deploys them into the regsitered compute manager. However, users have the option to do the same by deploying the Edge appliance anywhere, outside NSX, and registering it with NSX using the Edge CLI or OVA parameters. Later, this Edge appliance can be converted into a transport node using NSX API - this change attempts to utilize this capability. Fixes: vmware#1459 Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
edge_ova_create
branch
from
039889c to
d1545a1
Compare
Normally users create Edge Transport Nodes within NSX, which deploys them into the regsitered compute manager. However, users have the option to do the same by deploying the Edge appliance anywhere, outside NSX, and registering it with NSX using the Edge CLI or OVA parameters. Later, this Edge appliance can be converted into a transport node using NSX API - this change attempts to utilize this capability.
Fixes: #1459