-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Voila shell #1369
Update Voila shell #1369
Conversation
@jtpio @martinRenou I'm trying to do a quick hack to make the shell extensible, but can not use the same layout system as in JupyterLab since the widgets do not show up. Not sure if we should ship this in 0.5.0 or if this feature needs more discussion. |
What do you mean by this? Wondering if these areas could be hidden by default, and visible if a widget is added to them?
I guess even if a partially working implementation would be available in 0.5.0 it would already be good. And could be polished for 1.0.0. For example maybe the theme toggle top bar extension from https://github.com/jupyterlab-contrib/jupyterlab-topbar could also be reused in Voila? |
I tried to mimic the Lab shell with a |
3483161
to
1529405
Compare
1529405
to
35cf923
Compare
Hi all, this PR is ready for review again. Now I have a properly working shell with the top, main and bottom areas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! Letting a bit of time for @jtpio to have a look
Did you have an example of an extension somewhere to was putting something in the top bar? If you agree, maybe this repo could go under the voila-dashboards org |
I'm working on it, will ping you to create the repo later |
Would it be possible to add a screenshot to have an idea of what the Voila dashboard looks like when there is a top bar component? Also being able to reuse one of the extensions from https://github.com/jupyterlab-contrib/jupyterlab-topbar would be great. |
The top and bottom are empty divs of 10px min-height and hidden by default. Their positions are fixed and the scrollbar is now shown inside the main content area.
I doubt it since |
I think we need to be careful not to break custom templates by adding this kind of things. Custom templates are tested on the CI so for now with just the top and bottom that seems ok to me! Look great! Thanks |
Doing another beta with this now |
Yeah the one used by these extensions is |
Add new config
VoillaConguration.extension_config
: this is a dict with keys are names of extensions, and values are the config value. This dict is passed to the frontend viaPageConfig
so the frontend extension can read its configs.Extension can now add widgets to the top and bottom of the voila shell.