Add threat model. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbleness
reviewed
Oct 16, 2024
flarss34
reviewed
Oct 28, 2024
zbleness
reviewed
Nov 4, 2024
threat_model/threat_model.md
Outdated
| |||||| Medium | Deploy IDS to increase chance of detection | Test deployment for IDS presence | ||
| | UC1:3 | CVA, CNA | Return malicious state to user which steals data from deployment if deployed | High | Medium | High | Protect traffic with TLS + proper certificates | Test that TVB refuses to talk to HTTP or self-signed Vault | ||
| | UC1:3 | CNA | Eavesdrop on returned TF state to obtain secrets | High | Medium | High | Protect traffic with TLS | See above | ||
| | UC1:3 | CTA | Leak secrets obtained from Vault | High | Low | High | Ensure dependencies are minimal, trustworthy, and up to date | Use automatic dependency scanning in CI |
There was a problem hiding this comment.
Another countermeasure is to turn off general egress traffic from TVA (like we are doing).
zbleness
requested changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are made in this PR?
This commit adds a formal threat model for the system.
Why are these changes needed?
We need a threat model if we're serious about security hardening this backend. Once we've done that, having one will increase people's confidence in it.
Related issues:
Closes #4.