Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken dependencies - \React\Socket\Server::__construct needs two arguments #13

Open
nepda opened this issue Oct 30, 2017 · 5 comments
Open

Comments

@nepda
Copy link

nepda commented Oct 30, 2017

If you install the voryx/wamppost package in version 0.1.5 (composer.json like below)

You will get an error because the usage of \React\Socket\Server::__construct has changed. But your code does'nt:

src/WampPost/WampPost.php:32:

        $this->socket = new Server($loop);

But the signature of the class looks like this:

    public function __construct($uri, LoopInterface $loop, array $context = array())

composer.json:

{
    "name": "nepda/wamp-post-example",
    "type": "project",
    "require": {
        "voryx/wamppost": "^0.1.5"
    }
}

@mbonneau
Copy link
Member

@nepda - There is a PR updating to the most recent socket and http libraries ( #12 ).

I would anticipate this will be merged this week. If not - ping me back.

@nepda
Copy link
Author

nepda commented Nov 10, 2017

Ping :)
Any progress here?

@mbonneau
Copy link
Member

@nepda #12 is currently blocked by react/http (https://github.com/reactphp/http/milestone/14). The newer updates to this library use features that will be in the 0.8.0 release of http. You can use the PR branch by requiring voryx/wampport:dev-http-version (you will probably have to require react/http:dev-master at the same time) in your project.

@nepda
Copy link
Author

nepda commented Nov 11, 2017

Okay, thanks. W'll work with this and looking forward to see react releasing 0.8.0. Thanks for your work!

@ImpactSeo
Copy link

Hey, it seems v8 is now released : https://github.com/reactphp/http/releases, it would be cool to get it merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants