New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design SDK structure, add support for v2018-08-01 #26

Open

bandraszyk opened this issue Jan 8, 2019 · 0 comments

Labels

breaking change

bandraszyk commented Jan 8, 2019

The sdk structure should be redesigned so it's more similar to nodejs sdk (https://github.com/voucherifyio/voucherify-nodejs-sdk/tree/master/src):

common methods (utils) should be placed in separated file
every namespace should be placed in separated file and it should contain methods only from that namespace
add support for all methods from v2018-08-01 (https://docs.voucherify.io/v2018-08-01/reference) as breaking changes to validation rules has been introduced

Things to be done:

change structure
add support for v2018-08-01
check python version compatibility, 2.x vs 3.x (add proper tests if needed)
building and releasing automatisation: release new major version
update readme

bandraszyk added the breaking change label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment