From 2ec61c51d2448f4f4f37fb73ae8703bcfef40c06 Mon Sep 17 00:00:00 2001 From: Brett Bloxom Date: Thu, 23 May 2024 16:16:01 -0600 Subject: [PATCH 1/4] adds dealid property to bid responses --- modules/concertBidAdapter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/concertBidAdapter.js b/modules/concertBidAdapter.js index bc2c4555c54..1912f8c332d 100644 --- a/modules/concertBidAdapter.js +++ b/modules/concertBidAdapter.js @@ -121,7 +121,8 @@ export const spec = { meta: { advertiserDomains: bid && bid.adomain ? bid.adomain : [] }, creativeId: bid.creativeId, netRevenue: bid.netRevenue, - currency: bid.currency + currency: bid.currency, + ...(bid.dealid && { dealId: bid.dealid }), }; }); From a1e0508ac3dc3d4571b36e8e92220e64ceba7e96 Mon Sep 17 00:00:00 2001 From: Brett Bloxom Date: Thu, 23 May 2024 16:51:15 -0600 Subject: [PATCH 2/4] updates tests --- test/spec/modules/concertBidAdapter_spec.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/spec/modules/concertBidAdapter_spec.js b/test/spec/modules/concertBidAdapter_spec.js index 40294deb26d..d09bf66a696 100644 --- a/test/spec/modules/concertBidAdapter_spec.js +++ b/test/spec/modules/concertBidAdapter_spec.js @@ -249,6 +249,16 @@ describe('ConcertAdapter', function () { }); }); + it('should include dealId when present in bidResponse', function() { + const bids = spec.interpretResponse({ ...bidResponse, dealid: 'CON-123' }, bidRequest); + expect(bids).to.have.property('dealId'); + }); + + it('should exclude dealId when absent in bidResponse', function() { + const bids = spec.interpretResponse(bidResponse, bidRequest); + expect(bids).to.not.have.property('dealId'); + }); + it('should return empty bids if there is no response from server', function() { const bids = spec.interpretResponse({ body: null }, bidRequest); expect(bids).to.have.lengthOf(0); From c3614c6e772bbd598182c3147f84b71636d8165b Mon Sep 17 00:00:00 2001 From: Brett Bloxom Date: Thu, 23 May 2024 16:58:16 -0600 Subject: [PATCH 3/4] use first bid for tests --- test/spec/modules/concertBidAdapter_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec/modules/concertBidAdapter_spec.js b/test/spec/modules/concertBidAdapter_spec.js index d09bf66a696..c3dce53d45e 100644 --- a/test/spec/modules/concertBidAdapter_spec.js +++ b/test/spec/modules/concertBidAdapter_spec.js @@ -251,12 +251,12 @@ describe('ConcertAdapter', function () { it('should include dealId when present in bidResponse', function() { const bids = spec.interpretResponse({ ...bidResponse, dealid: 'CON-123' }, bidRequest); - expect(bids).to.have.property('dealId'); + expect(bids[0]).to.have.property('dealId'); }); it('should exclude dealId when absent in bidResponse', function() { const bids = spec.interpretResponse(bidResponse, bidRequest); - expect(bids).to.not.have.property('dealId'); + expect(bids[0]).to.not.have.property('dealId'); }); it('should return empty bids if there is no response from server', function() { From e53bee2c70c783fcea2f20eba1c81467390dcc75 Mon Sep 17 00:00:00 2001 From: Brett Bloxom Date: Thu, 23 May 2024 17:02:55 -0600 Subject: [PATCH 4/4] adds dealid at the correct level --- test/spec/modules/concertBidAdapter_spec.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/spec/modules/concertBidAdapter_spec.js b/test/spec/modules/concertBidAdapter_spec.js index c3dce53d45e..d556236ba02 100644 --- a/test/spec/modules/concertBidAdapter_spec.js +++ b/test/spec/modules/concertBidAdapter_spec.js @@ -250,7 +250,13 @@ describe('ConcertAdapter', function () { }); it('should include dealId when present in bidResponse', function() { - const bids = spec.interpretResponse({ ...bidResponse, dealid: 'CON-123' }, bidRequest); + const bids = spec.interpretResponse({ + body: { + bids: [ + { ...bidResponse.body.bids[0], dealid: 'CON-123' } + ] + } + }, bidRequest); expect(bids[0]).to.have.property('dealId'); });