Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Addressable for handling URIs? #173

Closed
RST-J opened this issue Nov 2, 2014 · 1 comment
Closed

Use Addressable for handling URIs? #173

RST-J opened this issue Nov 2, 2014 · 1 comment

Comments

@RST-J
Copy link
Contributor

RST-J commented Nov 2, 2014

Several filed issues (#100, #109) and the latest discussion in #170 showed that there are problems with URIs. And there is at least one more, the following test currently fails:

    schema = {
      "$schema"=> "http://json-schema.org/draft-04/schema#",
      "id"=> "http://俺:鍵@例え.テスト/p?条件#ここ#",
      "type" => "object",
      "required" => ["a"],
      "properties" => {
        "a" => {
          "id" => "a",
          "type" => "integer"
        }
      }
    }
    data = { "a" => 5 }
    assert_valid schema, data

Using Addressable to have the mess about handling URIs covered - instead of doing it ourselves (which would likely fail) - got some consent.

I closed #170 and opened this issue to discuss the URI stuff in general and started to work on the Addressable integration.

@pd
Copy link
Contributor

pd commented Nov 25, 2014

Fixed by #174. Thanks for keeping up with all fo this @RST-J =)

@pd pd closed this as completed Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants