Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match to file_line jvm.options #1168

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Add match to file_line jvm.options #1168

merged 1 commit into from
Aug 27, 2022

Conversation

phaedriel
Copy link
Contributor

@phaedriel phaedriel commented Aug 26, 2022

Pull Request (PR) description

Add a match on file_line jvm_options (A=value) to remove old same parameter (A=oldvalue)

This Pull Request (PR) fixes the following issues

n/a

@smortex
Copy link
Member

smortex commented Aug 27, 2022

file_line sucks here, so it fix some issues. I guess that if we want this to be reliable we should forget file_line and manage the whole file with a template.

@smortex smortex merged commit aaf70a4 into voxpupuli:master Aug 27, 2022
@phaedriel phaedriel deleted the jvm_options_duplicate branch August 27, 2022 18:53
bmagistro added a commit to bmagistro/puppet-elasticsearch that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants